On Thu, 2020-01-16 at 14:41 -0700, Tom Hromatka wrote: > In fact, I prototyped that up quickly. Here are the two commits I > made for this: > https://github.com/drakenclimber/libcgroup/commit/bcf34c6fa7739f1dc69f190086e8ca398a8e42ab > https://github.com/drakenclimber/libcgroup/commit/f0faaa01600a30f593cbf7afd5328bc96452397f > > And here's the code coverage. I was able to achieve 100% coverage! > https://coveralls.io/builds/28160581/source?filename=src/api.c#L2620 > > I believe the logic is functionally correct.
Thanks, it looks good to me. But since the function returns a value, I suppose it would make sense to return an error if the "cgc" argument is NULL. Also, the counter variable could be "i" instead of "j". Regards, Nikola _______________________________________________ Libcg-devel mailing list Libcg-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libcg-devel
