On 3/29/21 7:32 AM, Michal Koutný wrote:
Hello.
On Fri, Mar 26, 2021 at 08:02:43AM -0600, Tom Hromatka
<tom.hroma...@oracle.com> wrote:
This patchset adds cgroup v2 support to cgclear.
IIUC, the "support" means that you can invoke cgclear on v2 system,
however, it effectively does nothing.
cgclear does two things:
1. delete all cgroups
2. unmount the controllers
So this change allows cgclear to delete v2 cgroups, but
as you pointed out it does not unmount the hierarchy.
I think it's best to continue support of cgclear through one
more release, but long term I think this is a tool that should
be deprecated.
I concur (to the latter part). Why introduce cgclear to v2 at all?
(Since it's just a dummy implementation anyway.)
See above. If you (or anyone else) feels strongly about
removing cgclear now, then I'm open to such a suggestion.
I figured I would get out one more "stable" release. Then
I'll start to make more extensive and non-backward-compatible
changes after that.
Now with systemd providing cgroup management, cgclear no longer makes
sense.
BTW I see that you skip 'name=systemd' during cgclear. It ocurred to me
that it'd be better to skip it straight from the beginning when parsing
into the mount table -- actually, there's already a config option for
that, see OPAQUE_HIERARCHY.
Good call on both accounts. I'll make those changes. Totally forgot
about the OPAQUE_HIERARCHY setting.
Thanks!
Tom
_______________________________________________
Libcg-devel mailing list
Libcg-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libcg-devel
