Fix the following strncpy() string truncation warning:

In function ‘strncpy’,
    inlined from ‘cgroup_parse_rules_file’ at api.c:814:3:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: warning: 
‘__builtin_strncpy’ output may be truncated copying 4095 bytes from a string of 
length 4095 [-Wstringop-truncation]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Tom Hromatka <tom.hroma...@oracle.com>
---
 src/api.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/api.c b/src/api.c
index 4e6e3b9e9545..51c4779eaf0f 100644
--- a/src/api.c
+++ b/src/api.c
@@ -813,6 +813,7 @@ static int cgroup_parse_rules_file(char *filename, bool 
cache, uid_t muid,
                }
                strncpy(newrule->destination, destination,
                        sizeof(newrule->destination) - 1);
+               newrule->destination[sizeof(newrule->destination) - 1] = '\0';
 
                if (has_options) {
                        ret = cgroup_parse_rules_options(options, newrule);
-- 
2.25.1



_______________________________________________
Libcg-devel mailing list
Libcg-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libcg-devel

Reply via email to