Fix the following strncpy() string truncation warning:
In function ‘strncat’,
inlined from ‘print_cgroup’ at lscgroup.c:149:4:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:136:10: warning:
‘__builtin___strncat_chk’ output
may be truncated copying between 0 and 4095 bytes from a string of length 4095
[-Wstringop-truncation]
136 | return __builtin___strncat_chk (__dest, __src, __len, __bos (__dest));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Tom Hromatka <[email protected]>
---
src/tools/lscgroup.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/tools/lscgroup.c b/src/tools/lscgroup.c
index 00493d973ac3..31d5c2e61957 100644
--- a/src/tools/lscgroup.c
+++ b/src/tools/lscgroup.c
@@ -148,6 +148,7 @@ static int print_cgroup(struct cgroup_group_spec
*cgroup_spec, int flags)
FILENAME_MAX-strlen(all_conts)-1);
strncat(all_conts, controller.name,
FILENAME_MAX-strlen(all_conts)-1);
+ all_conts[sizeof(all_conts) - 1] = '\0';
} else {
/* we got new mount point, print it if needed */
if (output) {
--
2.25.1
_______________________________________________
Libcg-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libcg-devel