On Jan 7, 2011, at 10:18 AM, Tomaž Muraus wrote: > Hello, > > I think we need to postpone the 0.4.1 release because I have unintentionally > brake API in the EC2 driver. > > list_locations method now returns a list of EC2NodeLocation objects instead > of a list of NodeLocation objects.
Thanks for catching that... I missed that as well. > I think we should change list_locations back to return a list of > NodeLocation objects and add another ex_list_locations method which returns > a list of EC2NodeLocation objects. > > Then we have three options for the create_node method: > > 1. Allow user to pass NodeLocation or EC2NodeLocation object for the > location keyword argument Since EC2NodeLocation is a subclass of NodeLocation, I think #1 would be fine. Then in create_node we can check for the class of kwargs['location'] and deal with the availability zone appropriately. Do you want to come up with a patch (and maybe use your brand new commit privileges :)), or do you want me to take a stab at it? Thanks, Jerry > 2. Allow user to pass in the ex_location keyword argument which must be an > instance of EC2NodeLocation > 3. Add ex_create_node which is the same as the create_node method but it > takes an instance of the EC2NodeLocation class for the location keyword > argument > > I am really sorry for this, I promise I will be more careful next time. > > On Wed, Jan 5, 2011 at 5:11 AM, Paul Querna <[email protected]> wrote: > >> it looks like the release tag didn't edit the version correctly: >> >> < >> https://svn.apache.org/repos/asf/incubator/libcloud/tags/0.4.1/libcloud/__init__.py >>> >> >> (its still 0.4.1-dev) >> >> I'd suggest re-rolling with it fixed. The process I used before was >> to remove the -dev from trunk, then make the tag, then increment + >> re-add -dev in trunk. >> >> >> On Tue, Jan 4, 2011 at 9:47 PM, Jerry Chen <[email protected]> wrote: >>> Hi all, >>> >>> Test tarballs for Apache Libcloud 0.4.1 are available at: >>> <http://people.apache.org/~jerry/libcloud-0.4.1/> >>> >>> Please test and place your votes: >>> >>> +/- 1 >>> [ ] Release Apache Libcloud 0.4.1 >>> >>> Vote closes on Sunday January 9, 2011 at 10pm PST. >>> >>> This release introduces new drivers, improvements to deployment >> capabilities, and libcloud.security module for SSL certificate verification. >>> >>> For more information on SSL verification: >>> <http://wiki.apache.org/incubator/LibcloudSSL> >>> >>> For the full list of changes, see: >>> <https://svn.apache.org/repos/asf/incubator/libcloud/tags/0.4.1/CHANGES >>> >>> >>> Cheers, >>> Jerry >>
