Mike Alexander writes: > Thanks. Unfortunately I noticed a couple of issues with this patch. > One of the data types supported by the union is DBI_INTEGER_SIZE3 but > the union doesn't have a 3 byte integer field. My change yesterday > treated it as if it were a 2 byte field, but looking closer I see that > the rest of the code treats it as if it were a 4 byte field. I've > attached a new patch that fixes this. All that's needed is moving 2 > "case DBI_INTEGER_SIZE3" statements one or two lines later. >
Thanks, I've checked in the updated version. Runs ok on FreeBSD. > The other thing I noticed is that the Oracle driver still has an endian > problem. It lies about the type in the dbi_data_t struct that it > returns. It stores a long long value for all DBI_INTEGER_SIZE* types. > This won't work on a big endian machine (after my changes). See the > code around line 640 in dbd_oracle.c to see what I'm talking about. > Since I don't have Oracle or documentation for its API, this is not > something I'm prepared to fix. Neither am I. We're in dire need of an oracle maintainer. In any case, we're moving to a new test framework which should make these problems obvious, as long as we find someone who tests oracle on PowerPC... regards, Markus -- Markus Hoenicka markus.hoeni...@cats.de (Spam-protected email: replace the quadrupeds with "mhoenicka") http://www.mhoenicka.de ------------------------------------------------------------------------------ Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers & brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, & iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian Group, R/GA, & Big Spaceship. http://www.creativitycat.com _______________________________________________ libdbi-devel mailing list libdbi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libdbi-devel
