On Thu, Aug 03, 2017 at 06:08:24PM +0200, Pino Toscano wrote: > But I guess I have no chance to change the current patch (even adding > a test using asserts, instead of oUnit, for which I still did not get > a reason why a new test using it would be unacceptable), so ...
Fewer dependencies make the code easier for others to consume, and that's especially true when (like oUnit) those dependencies add little value. (That's different from dependencies like, say, Augeas which bring huge value.) So by adding a test with asserts I'm gradually working towards reducing -- or at least not increasing -- the amount of oUnit being used. Practically, someone who compiles libguestfs and runs the tests but doesn't have oUnit installed will be able to run this test, whereas the oUnit-based tests would be skipped. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org _______________________________________________ Libguestfs mailing list [email protected] https://www.redhat.com/mailman/listinfo/libguestfs
