On 02.02.2007 [10:10:11 -0600], Steve Fox wrote: > On Thu, 2007-02-01 at 18:27 -0800, Nishanth Aravamudan wrote: > > > Another note, here, I've got a much more invasive version of this patch > > which is mostly just a cleanup once we've decided if we're going to > > store extra fields in the seg_info struct. It cleans up do_extracopy to > > just store into those fields directly and makes a bit of that code > > easier to follow, I think. Maybe it's better to save extra_start and > > extra_end in that case (rather than extra_start and an extra_size)? Any > > feedback would be appreciated. > > I like this idea. Storing extra_vaddr and extrasz instead would > replace some arithmetic with comparisons which may be better. I don't > think there was a real good reason why we went with start and end.
Ok, well, start and end would remove an extra addition in the pagecache loop, but may not be super important. I'll spin some patches with both varieties and we can decide which is cleaner (and I'll probably need your help, Steve, in verifying they are functionally equivalent). > P.S. This is all post-1.1 stuff I hope? :) Yes. Thanks, Nish -- Nishanth Aravamudan <[EMAIL PROTECTED]> IBM Linux Technology Center ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Libhugetlbfs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
