On 04.03.2007 [10:24:33 +1100], David Gibson wrote: > On Fri, Mar 02, 2007 at 05:12:31PM -0800, Nishanth Aravamudan wrote: > > On 03.03.2007 [11:51:31 +1100], David Gibson wrote: > > > On Fri, Mar 02, 2007 at 03:52:42PM -0800, Nishanth Aravamudan wrote: > > > > On 02.03.2007 [15:12:06 -0800], Nishanth Aravamudan wrote: > > > > > Makefile: add ia64, sparc64 support for functional tests only > > > > > > > > > > Add simple support for ia64 and sparc64. We avoid doing the relink > > > > > tests > > > > > by adding another environment variable which only ia64 and sparc64 > > > > > define, which is checked in tests/Makefile. Also, explicitly fail to > > > > > build on other architectures rather than silently doing nothing. > > > > > > > > Makefile: add ia64, sparc64 support for functional tests only > > > > > > > > Add simple support for ia64 and sparc64. We avoid doing the relink and > > > > malloc tests by adding environment variables only defined for ia64 and > > > > sparc64, which then are checked in tests/Makefile. Also, explicitly fail > > > > to build on other architectures rather than silently doing nothing. > > > > Finally, remove the unused dummy test from the Makefile and > > > > run_tests.sh. > > > > > > Rather than adding a new variable to stop the relink tests, why don't > > > you just check for the absence of the ELF32 and ELF64 variables? > > > > Because I'm dumb? :) Good point, updated patch below: > > > > Makefile: add ia64, sparc64 support for functional tests only > > > > Add simple support for ia64 and sparc64. We avoid doing the relink tests > > by checking for ELF32/ELF64 emptiness and malloc tests by adding an > > environment variable only defined for ia64 and sparc64, which then is > > checked in tests/Makefile. Also, explicitly fail to build on other > > architectures rather than silently doing nothing. Finally, remove the > > unused dummy test from the Makefile and run_tests.sh. > > Oh, also... > [snip] > > +ifeq ($(ARCH),ia64) > > +CC64 = gcc > > +LIB64 = lib64 > > +ARCH_MORECORE_NOT_SUPPORTED = 1 > > +else > > +ifeq ($(ARCH),sparc64) > > +CC64 = gcc -m64 > > +LIB64 = lib64 > > +ARCH_MORECORE_NOT_SUPPORTED = 1 > > +else > > Why doesn't morecore support work, at least on sparc?
Well, it's more like ARCH_MORECORE_NOT_TESTED :) I don't have access to either ia64 or sparc64 right now (although I am going to try and get two ia64 boxen with sufficient RAM working on Monday). Thanks, Nish -- Nishanth Aravamudan <[EMAIL PROTECTED]> IBM Linux Technology Center ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Libhugetlbfs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
