On 04.03.2007 [18:51:53 +1100], David Gibson wrote:
> On Sat, Mar 03, 2007 at 09:35:56PM -0800, Nishanth Aravamudan wrote:
> [snip]
> > > [snip]
> > > > +ifeq ($(ARCH),ia64)
> > > > +CC64 = gcc
> > > > +LIB64 = lib64
> > > > +ARCH_MORECORE_NOT_SUPPORTED = 1
> > > > +else
> > > > +ifeq ($(ARCH),sparc64)
> > > > +CC64 = gcc -m64
> > > > +LIB64 = lib64
> > > > +ARCH_MORECORE_NOT_SUPPORTED = 1
> > > > +else
> > > 
> > > Why doesn't morecore support work, at least on sparc?
> > 
> > Well, it's more like ARCH_MORECORE_NOT_TESTED :) I don't have access to
> > either ia64 or sparc64 right now (although I am going to try and get two
> > ia64 boxen with sufficient RAM working on Monday).
> 
> Hrm, if it's just that it's not tested, then we really should leave
> the tests in, so's we can test it...

Ok, updated:

Makefile: add ia64, sparc64 support for functional tests only

Add simple support for ia64 and sparc64. We avoid doing the relink tests
by not defining the ELF prefixes for either arch. Simply adding the
linker scripts and the entries to the Makefile should make those tests
build/run. Also, explicitly fail to build on other architectures rather
than silently doing nothing.  Keep the otherwise unused dummy test in
the Makefile, because the object file is used by zero_filesize_segment,
but remove it from run_tests.sh.

Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]>

diff --git a/Makefile b/Makefile
index d169042..538acd1 100644
--- a/Makefile
+++ b/Makefile
@@ -48,6 +48,18 @@ ifneq ($(BUILDTYPE),NATIVEONLY)
 CC32 = gcc -m32
 ELF32 = elf_i386
 endif
+else
+ifeq ($(ARCH),ia64)
+CC64 = gcc
+LIB64 = lib64
+else
+ifeq ($(ARCH),sparc64)
+CC64 = gcc -m64
+LIB64 = lib64
+else
+$(error "Unrecognized architecture ($(ARCH))")
+endif
+endif
 endif
 endif
 endif
diff --git a/tests/Makefile b/tests/Makefile
index 6939784..cccb5c8 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -22,9 +22,10 @@ LDFLAGS32 = -L../obj32
 LDFLAGS64 = -L../obj64
 INSTALL = install
 
-TESTS = $(LIB_TESTS) $(NOLIB_TESTS) $(LDSCRIPT_TESTS) $(HUGELINK_TESTS) \
-       $(HUGELINK_TESTS:%=xB.%) $(HUGELINK_TESTS:%=xBDT.%) \
-       $(STRESS_TESTS)
+TESTS = $(LIB_TESTS) $(NOLIB_TESTS) $(LDSCRIPT_TESTS) $(STRESS_TESTS)
+ifneq ($(or $(ELF32),$(ELF64)),)
+TESTS += $(HUGELINK_TESTS) $(HUGELINK_TESTS:%=xB.%) $(HUGELINK_TESTS:%=xBDT.%)
+endif
 
 TESTS_64 = $(LIB_TESTS_64)
 
diff --git a/tests/run_tests.sh b/tests/run_tests.sh
index 3ab4532..6b6f1bb 100755
--- a/tests/run_tests.sh
+++ b/tests/run_tests.sh
@@ -125,7 +125,6 @@ restore_shm_sysctl() {
 }
 
 functional_tests () {
-    #run_test dummy
 # Kernel background tests not requiring hugepage support
     run_test zero_filesize_segment
 
-- 
Nishanth Aravamudan <[EMAIL PROTECTED]>
IBM Linux Technology Center

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Libhugetlbfs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel

Reply via email to