On Thu, 2008-07-03 at 15:16 +1000, David Gibson wrote: > On Thu, Jul 03, 2008 at 05:41:59AM +0100, Mel Gorman wrote: > > On (03/07/08 13:32), David Gibson didst pronounce: > > > On Thu, Jul 03, 2008 at 03:18:29AM +0100, Mel Gorman wrote: > > > > The recent bug with private-reserves should have been caught during > > > > 64-bit > > > > testing but wasn't because a manual verification of the meminfo file was > > > > necessary and the tests otherwise seemed fine. This patch verifies the > > > > counters are the same before and after each test in the regression suite > > > > and aborts the test if it finds anything suspicious. > > > > > > Hrm. Given that typically we continue the rest of the tests on > > > failure, I don't really like the idea of aborting. I'd instead treat > > > this as a new sort of test result, distinct from PASS, FAIL and > > > CONFIG. > > > > > > > What would be your suggestion? To me, it's a chronic kernel failure that > > makes all further tests meaningless. I'd hate for it to be accidently > > missed. > > Eh. Same's true of a testcase SIGKILLed due to a kernel oops. > > > > print a summary of the number of passes/failures/etc. at the end of > > > the run. > > > > > > > Although I like this idea either way. > > Well, here you go then. > > libhugetlbfs: Print summary of testsuite results > > This patch adds some tracking to the run_tests script which counts the > total number of tests, and the number of passes, failures and other > results. This is printed as a summary once the script is finished, so > you can see at a glance if the tests ran clean or not. > > Signed-off-by: David Gibson <[EMAIL PROTECTED]> > > --- > tests/run_tests.sh | 41 ++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 40 insertions(+), 1 deletion(-) > > Index: libhugetlbfs/tests/run_tests.sh > =================================================================== > --- libhugetlbfs.orig/tests/run_tests.sh 2008-07-03 15:15:46.000000000 > +1000 > +++ libhugetlbfs/tests/run_tests.sh 2008-07-03 15:15:48.000000000 +1000 > @@ -7,6 +7,17 @@ unset HUGETLB_MORECORE > > ENV=/usr/bin/env > > +for BITS in 32 64; do > + tot_tests[$BITS]=0 > + tot_tests[$BITS]=0
Accidentally duplicated line? -- Adam Litke - (agl at us.ibm.com) IBM Linux Technology Center ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ Libhugetlbfs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
