On 03.07.2008 [12:11:39 -0500], Andrew Hastings wrote:
> Nishanth Aravamudan wrote:
>> On 03.07.2008 [10:04:01 -0500], Andrew Hastings wrote:
>>> David Gibson wrote:
>>>> @@ -49,6 +74,9 @@ run_test () {
>>>> skip_test () {
>>>> echo "$@: SKIPPED"
>>>> + for bits in $WORDSIZES; do
>>>> + tot_skip=$[tot_skip + 1]
>>>> + done
>>>> }
>>> I was going to ask:
>>> Shouldn't skip_test() also increment tot_tests[$bits]?
>>> Shouldn't there be a [$bits] subscript on tot_skip?
>>
>> Probably?
>>
>>> But then I noticed that skip_test() doesn't seem to be called from
>>> anywhere. Perhaps it should be removed?
>>
>> Well, it's there mostly to allow us to manually skip tests when we know
>> they cause the kernel to panic. And there's no real overhead to having
>> an uncalled shell script function which might be necessary later on.
>
> Makes sense. Probably worth a comment, though:
Care to shoot me a quick patch? :)
Thanks,
Nish
--
Nishanth Aravamudan <[EMAIL PROTECTED]>
IBM Linux Technology Center
-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
Libhugetlbfs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
