On (20/08/08 13:59), David Gibson didst pronounce:
> This patch adds some tracking to the run_tests script which counts the
> total number of tests, and the number of passes, failures and other
> results. This is printed as a summary once the script is finished, so
> you can see at a glance if the tests ran clean or not.
>
> Signed-off-by: David Gibson <[EMAIL PROTECTED]>
>
Thanks David, looking good. Running this on a crash laptop and I got
********** TEST SUMMARY
* 32-bit 64-bit
* Total testcases: 83 0
* Skipped: 0 0
* PASS: 73 0
* FAIL: 7 0
* Killed by signal: 0 0
* Bad configuration: 3 0
* Strange test result: 0 0
**********
which is a bit more digestible than what we currently have and will be easier
to automate checking for new regressions. A few comments below
> ---
> tests/run_tests.sh | 41 ++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 40 insertions(+), 1 deletion(-)
>
> Submitted this one a while back, but it seems to have slipped through
> the cracks.
>
> Index: libhugetlbfs/tests/run_tests.sh
> ===================================================================
> --- libhugetlbfs.orig/tests/run_tests.sh 2008-07-28 14:53:07.000000000
> +1000
> +++ libhugetlbfs/tests/run_tests.sh 2008-07-28 14:53:08.000000000 +1000
> @@ -11,6 +11,16 @@ export HUGETLB_VERBOSE
>
> ENV=/usr/bin/env
>
> +for BITS in 32 64; do
> + tot_tests[$BITS]=0
> + tot_pass[$BITS]=0
> + tot_fail[$BITS]=0
> + tot_config[$BITS]=0
> + tot_signal[$BITS]=0
> + tot_strange[$BITS]=0
> + tot_skip[$BITS]=0
> +done
> +
> function free_hpages() {
> H=$(grep 'HugePages_Free:' /proc/meminfo | cut -f2 -d:)
> [ -z "$H" ] && H=0
> @@ -54,8 +64,22 @@ run_test_bits () {
> shift
>
> if [ -d obj$BITS ]; then
> + tot_tests[$BITS]=$[tot_tests[$BITS] + 1]
> echo -n "$@ ($BITS): "
> - PATH="obj$BITS:$PATH"
> LD_LIBRARY_PATH="$LD_LIBRARY_PATH:../obj$BITS:obj$BITS" $ENV "$@"
> + if PATH="obj$BITS:$PATH"
> LD_LIBRARY_PATH="$LD_LIBRARY_PATH:../obj$BITS:obj$BITS" $ENV "$@"; then
> + tot_pass[$BITS]=$[tot_pass[$BITS] + 1]
> + else
> + rc="$?"
> + if [ "$rc" == "1" ]; then
> + tot_config[$BITS]=$[tot_config[$BITS] + 1]
> + elif [ "$rc" == "2" ]; then
> + tot_fail[$BITS]=$[tot_fail[$BITS] + 1]
> + elif [ "$rc" -gt 127 ]; then
> + tot_signal[$BITS]=$[tot_signal[$BITS] + 1]
> + else
> + tot_strange[$BITS]=$[tot_strange[$BITS] + 1]
> + fi
> + fi
It's a pity we depend on magic numbers here. Could we do something like
the following at the start?
grep RC hugetests.h | grep define | awk '{print $2"="$3}' > rc.sh
. rc.sh
if [ "$rc" = "$RC_CONFIG" ]; then
tot_config[$BITS]=$[tot_config[$BITS] + 1]
etc.
?
> fi
> }
>
> @@ -69,6 +93,10 @@ run_test () {
> # replace "run_test <options>" with "skip_test <options>".
> skip_test () {
> echo "$@: SKIPPED"
> + for bits in $WORDSIZES; do
> + tot_tests[$bits]=$[tot_tests[$bits] + 1]
> + tot_skip[$bits]=$[tot_skip[$bits] + 1]
> + done
> }
>
Looks ok
> maybe_run_linkhuge_test () {
> @@ -350,3 +378,14 @@ for set in $TESTSETS; do
> ;;
> esac
> done
> +
> +echo -e "********** TEST SUMMARY"
> +echo -e "* 32-bit\t64-bit"
> +echo -e "* Total testcases: ${tot_tests[32]}\t${tot_tests[64]}"
> +echo -e "* Skipped: ${tot_skip[32]}\t${tot_skip[64]}"
> +echo -e "* PASS: ${tot_pass[32]}\t${tot_pass[64]}"
> +echo -e "* FAIL: ${tot_fail[32]}\t${tot_fail[64]}"
> +echo -e "* Killed by signal: ${tot_signal[32]}\t${tot_signal[64]}"
Tiny whitespace damage there. Used spaces instead of tabs.
> +echo -e "* Bad configuration: ${tot_config[32]}\t${tot_config[64]}"
> +echo -e "* Strange test result: ${tot_strange[32]}\t${tot_strange[64]}"
> +echo -e "**********"
>
>
>
> --
> David Gibson | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_
> _other_
> | _way_ _around_!
> http://www.ozlabs.org/~dgibson
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Libhugetlbfs-devel mailing list
> Libhugetlbfs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
>
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Libhugetlbfs-devel mailing list
Libhugetlbfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
