On Wed, Aug 20, 2008 at 11:39:54AM +0100, Mel Gorman wrote:
> On (20/08/08 13:59), David Gibson didst pronounce:
> > This patch adds some tracking to the run_tests script which counts the
> > total number of tests, and the number of passes, failures and other
> > results. This is printed as a summary once the script is finished, so
> > you can see at a glance if the tests ran clean or not.
> >
> > Signed-off-by: David Gibson <[EMAIL PROTECTED]>
> >
>
> Thanks David, looking good. Running this on a crash laptop and I got
>
> ********** TEST SUMMARY
> * 32-bit 64-bit
> * Total testcases: 83 0
> * Skipped: 0 0
> * PASS: 73 0
> * FAIL: 7 0
> * Killed by signal: 0 0
> * Bad configuration: 3 0
> * Strange test result: 0 0
> **********
>
> which is a bit more digestible than what we currently have and will
> be easier to automate checking for new regressions. A few comments
> below
Glad you think so.
[snip]
> > + rc="$?"
> > + if [ "$rc" == "1" ]; then
> > + tot_config[$BITS]=$[tot_config[$BITS] + 1]
> > + elif [ "$rc" == "2" ]; then
> > + tot_fail[$BITS]=$[tot_fail[$BITS] + 1]
> > + elif [ "$rc" -gt 127 ]; then
> > + tot_signal[$BITS]=$[tot_signal[$BITS] + 1]
> > + else
> > + tot_strange[$BITS]=$[tot_strange[$BITS] + 1]
> > + fi
> > + fi
>
> It's a pity we depend on magic numbers here. Could we do something like
> the following at the start?
>
> grep RC hugetests.h | grep define | awk '{print $2"="$3}' > rc.sh
> . rc.sh
>
> if [ "$rc" = "$RC_CONFIG" ]; then
> tot_config[$BITS]=$[tot_config[$BITS] + 1]
> etc.
>
> ?
Well.. I suppose we could. But there are enough moving parts in that,
that I'm not sure it will actually be more reliable or maintainable
than the magic numbers.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Libhugetlbfs-devel mailing list
Libhugetlbfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
