On Mon, Oct 20, 2008 at 12:13:38PM +0100, Mel Gorman wrote:
> On Fri, Oct 17, 2008 at 05:14:13PM +0100, Andy Whitcroft wrote:
> > Signed-off-by: Andy Whitcroft <[EMAIL PROTECTED]>
> > ---
> > hugetlbfs.h | 1 -
> > kernel-features.c | 4 ++--
> > libhugetlbfs_internal.h | 3 +++
> > 3 files changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/hugetlbfs.h b/hugetlbfs.h
> > index 06c427f..fc23f9f 100644
> > --- a/hugetlbfs.h
> > +++ b/hugetlbfs.h
> > @@ -25,7 +25,6 @@ long gethugepagesize(void);
> > int gethugepagesizes(long pagesizes[], int n_elem);
> > int getpagesizes(long pagesizes[], int n_elem);
> > int hugetlbfs_test_path(const char *mount);
> > -long hugetlbfs_test_pagesize(const char *mount);
> > const char *hugetlbfs_find_path(void);
> > const char *hugetlbfs_find_path_for_size(long page_size);
> > int hugetlbfs_unlinked_fd(void);
> > diff --git a/kernel-features.c b/kernel-features.c
> > index 12ca644..89f76b6 100644
> > --- a/kernel-features.c
> > +++ b/kernel-features.c
> > @@ -158,7 +158,7 @@ int hugetlbfs_test_feature(int feature_code)
> > return feature_mask & (1 << feature_code);
> > }
> >
> > -void print_valid_features(void)
> > +static void print_valid_features(void)
> > {
> > int i;
> >
> > @@ -169,7 +169,7 @@ void print_valid_features(void)
> > kernel_features[i].name);
> > }
> >
> > -int check_features_env_valid(const char *env)
> > +static int check_features_env_valid(const char *env)
> > {
> > const char *pos = env;
> > int i;
> > diff --git a/libhugetlbfs_internal.h b/libhugetlbfs_internal.h
> > index da84234..3ee2c51 100644
> > --- a/libhugetlbfs_internal.h
> > +++ b/libhugetlbfs_internal.h
> > @@ -136,4 +136,7 @@ extern ElfW(Word) plt_extrasz(ElfW(Dyn) *dyntab);
> > #define PROC_HUGEPAGES_DIR "/proc/sys/vm/"
> > #define SYSFS_HUGEPAGES_DIR "/sys/kernel/mm/hugepages/"
> >
> > +#define hugetlbfs_test_pagesize __lh_hugetlbfs_test_pagesize
> > +long hugetlbfs_test_pagesize(const char *mount);
> > +
>
> If it is being made static, does it need to be in the header at all?
No as Adam noticed this third function has been changed and not
documented. This third function is library local. Basically this
should be a separate patch and I will un-conflate them.
> > #endif /* _LIBHUGETLBFS_INTERNAL_H */
> > --
> > 1.6.0.2.711.gf1ba4
-apw
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Libhugetlbfs-devel mailing list
Libhugetlbfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
