On Mon, Oct 20, 2008 at 12:31:15PM +0100, Andy Whitcroft wrote:
> > 
> > Another spaces vs tabs here, but again barely worth getting into a
> > twist over.
> > 
> > >   while (ret != -1) {
> > >           ret = getopt_long(argc, argv, opts, long_opts, &index);
> > > -- 
> > > 1.6.0.2.711.gf1ba4
> > > 
> 
> I had not changed the spacing to keep the change purly mechanical.  I
> guess we should audit things for whitespace generally (as I have noticed
> a poor line endings here and there) and sort it out, perhaps after the
> next release as a global thing while noone has any patches out standing?
> 

I pointed it out as I noticed in case you wanted to fix up minor issues
while you were there. The patch is fine as-is. I don't see the need to do
a whitespace/padding cleanup as it confuses git-blame to me.

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Libhugetlbfs-devel mailing list
Libhugetlbfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel

Reply via email to