> Hey!  If it's "Beat Up On Roy" day, could we celebrate by pointing to
> some specific obfuscated examples?  :-)  I'm not using GCC4.3 yet, so
> I'm not going to try to guess what redundant parentheses would be
> necessary to make that compiler happy, but if I've been writing code
> that makes humans unhappy then I'd like to at least get some (more)
> explanatory comments in there.  If there's anything that's confusing
> you now, it'll probably be confusing me a year from now when I reread
> the same source after having forgotten the process of writing it.

;-)

src/mesh/mesh_refinement_smoothing.C:325:
  warning: suggest parentheses around && within ||

      if (h_flag_me &&
          (neighbor->level() < my_level) ||
          ((neighbor->active()) &&
           (neighbor->refinement_flag() != Elem::REFINE))
              || (neighbor->refinement_flag() ==
                  Elem::COARSEN_INACTIVE))
            {


I'm not sure that any amount of ()'s will preclude the need for a long, hard
stare to figure this one out.


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Libmesh-devel mailing list
Libmesh-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmesh-devel

Reply via email to