On Mon, Jun 16, 2008 at 10:38 AM, Roy Stogner <[EMAIL PROTECTED]> wrote:
>
> On Mon, 16 Jun 2008, John Peterson wrote:
>
>> On the other hand I find, Roy's complex logic statements hard to
>> understand because I'm surely not the coder he is :)  but I don't
>> think the compiler should warn about this code either (assuming it's
>> correct!)  I'm sure he put considerable effort into obfuscating it; we
>> don't need the compiler nanny to come along and confirm that fact ;-)
>
> Hey!  If it's "Beat Up On Roy" day, could we celebrate by pointing to

Beat Up On Roy day sounds fun!  I think I missed it last year...

> some specific obfuscated examples?  :-)  I'm not using GCC4.3 yet, so
> I'm not going to try to guess what redundant parentheses would be
> necessary to make that compiler happy, but if I've been writing code
> that makes humans unhappy then I'd like to at least get some (more)
> explanatory comments in there.  If there's anything that's confusing
> you now, it'll probably be confusing me a year from now when I reread
> the same source after having forgotten the process of writing it.

This one isn't too bad b/c there are only && and != but you get the idea.

mesh_refinement_smoothing.C, line 161

  if (node0 != childnode0 && node0 != childnode1
         && node1 != childnode0 && node1 != childnode1)
    break;

but the compiler might complain?

-J

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Libmesh-devel mailing list
Libmesh-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmesh-devel

Reply via email to