Agreed.  We gotta draw the line somewhere...  Can you imagine how far down the 
rabbit hole we would go if to avoid const_cast we changed the underlying c 
libraries?  

Now, though the conundrum.  Unless we add -Wall to the libmesh opt flags your 
changes will atrophy, but I don't want thousands of lines of warnings from 
contrib...

Perhaps we need

libmesh_only_CXXFLAGS += -Wall ...

??



----- Original Message -----
From: [EMAIL PROTECTED] <[EMAIL PROTECTED]>
To: John Peterson <[EMAIL PROTECTED]>
Cc: [email protected] <[email protected]>
Sent: Tue Jul 08 17:25:00 2008
Subject: Re: [Libmesh-devel] Fun with -Wall


On Tue, 8 Jul 2008, John Peterson wrote:

> On a related note, the contributed packages were also built with
> -Wall, which, between laspack, metis, parmetis, netcdf, and exodusII
> resulted in around 2000 lines of warnings.  I guess we could try to
> fix these (most of them are your garden variety "may be used
> uninitialized" and "discards qualifiers" C errors) but it would take
> awhile.
>
> What do you think?

I'd rather not.  If we want to bug and send a patch to the maintainers
of those packages, that's one thing, but let's not fork their code.
---
Roy

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
Libmesh-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libmesh-devel
-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
Libmesh-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libmesh-devel

Reply via email to