On Tue, Jul 8, 2008 at 5:34 PM, Kirk, Benjamin (JSC-EG) <[EMAIL PROTECTED]> wrote: > Agreed. We gotta draw the line somewhere... Can you imagine how far down > the rabbit hole we would go if to avoid const_cast we changed the underlying > c libraries?
OK, so I'd say the "nays" have it. It's also really easy to imagine breaking a contributed library while fixing warnings, which would really have us going backwards. > Now, though the conundrum. Unless we add -Wall to the libmesh opt flags > your changes will atrophy, but I don't want thousands of lines of warnings > from contrib... I wouldn't worry about it too much. After over 5 years of development I could still fix all the libmesh warnings in a single afternoon. And this type of stuff is *not* what you want to be worrying about while you're developing ... you often don't know whether a given variable will eventually be needed for code or just inside an assert. > Perhaps we need > > libmesh_only_CXXFLAGS += -Wall ... I'd vote for once a year or so doing 'libmesh_CXXFLAGS=-Wall ./configure; make' seeing what pops up, and fixing if necessary. -- John ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ Libmesh-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libmesh-devel
