On Tue, 2 Nov 2010, Boyce Griffith wrote:

> I haven't gone digging around in the headers; however, I just had to update 
> some code to account for the change of PeriodicBoundary::translation_vector 
> from public to protected, and the following:
>
>   VectorValue<double> boundary_translation(2.0*M_PI*R, 0.0, 0.0);
>   PeriodicBoundary pbc(boundary_translation);
>
> would not compile without including point.h ahead of periodic_boundaries.h. 
> I think that this was the offending method:
>
>  virtual Point get_corresponding_pos(const Point & pt)
>  {
>    return pt + translation_vector;
>  }
>
> This looks like a very recent change:

Ah, so recent that I hadn't actually checked it out in the sandbox on
my laptop yet.  You're absolutely right.

Thanks for the catch and the clarification; it should be fixed in the
svn head now.

Also importantly, "make test_headers" should be fixed in the svn head
now - previously it was only working if you had LIBMESH_DIR set, and
it was failing silently in our BuildBot regression tests.  Hopefully
if someone commits an update with a missing dependency in the future
we can catch it in tests before someone catches it in user code.
---
Roy

------------------------------------------------------------------------------
Achieve Improved Network Security with IP and DNS Reputation.
Defend against bad network traffic, including botnets, malware, 
phishing sites, and compromised hosts - saving your company time, 
money, and embarrassment.   Learn More! 
http://p.sf.net/sfu/hpdev2dev-nov
_______________________________________________
Libmesh-devel mailing list
Libmesh-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmesh-devel

Reply via email to