On Mon, 11 Apr 2011, Derek Gaston wrote: > The problem is that you can't call is_child_on_side on a RemoteElem. > This was happening in Elem::active_family_tree_by_side() (even when > the base of that tree was _not_ a RemoteElem itself). All I've done > is put a check in to make sure it's not a RemoteElem.... but I am > wondering if this could have some adverse effects. > > What do you think?
Hmm... active_family_tree_by_side should never be called on a RemoteElem... *except* in the case where it's being called from active_family_tree_by_side on the RemoteElem's parent. In that case it should be okay to first test for RemoteElem children and skip the call on them. However, it would be nice in DEBUG mode to still do the is_child_on_side test (on the parent rather than the RemoteElem child) and make sure that we don't actually have any RemoteElem children that should be on the queried side. Hmmm... it would also be nice if is_child_on_side was *correct*! Looking at the code again it appears that it's going to return a false negative for the mid-triangular-side elements on tets and prisms! --- Roy ------------------------------------------------------------------------------ Forrester Wave Report - Recovery time is now measured in hours and minutes not days. Key insights are discussed in the 2010 Forrester Wave Report as part of an in-depth evaluation of disaster recovery service providers. Forrester found the best-in-class provider in terms of services and vision. Read this report now! http://p.sf.net/sfu/ibm-webcastpromo _______________________________________________ Libmesh-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libmesh-devel
