On Fri, 10 Jun 2011, David Andrs wrote: > So we bumped into another issue with the recent libMesh update. It > seems that System::update() does not close() the solution vector any > more, however this call is crucial if the solution vector is > ghosted.
Almost. This call is crucial if the solution vector is ghosted and not already closed. But it's also redundant global communication if the solution vector is already closed, which (without any special effort in user-level code) is the case for every update() call in our examples and in the apps I've tested. > Attached is the patch that fixes it. Could you identify where in your failure case the solution vector is getting left open? If there's some place in the library that should be closing vectors but is failing to, then that's where we ought to fix it. (e.g. I caught one of those in our NOX interface yesterday) If not, then there's some place in user code that should be closing vectors but is failing to, and IMHO that's where you ought to fix it. We could instead just apply another close()... but there are dozens of places in the library where we assert that a vector or matrix is closed. If we're going to start replacing some of those with usually-redundant close() calls, why do it piecemeal? Does anyone want to replace them all? --- Roy ------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Libmesh-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libmesh-devel
