"by default, does nothing to maintain backward compatibility" should read "by default does nothing, to maintain backward compatibility". Sentences which reverse meaning based on comma placement are always amusing.
I wouldn't call the thread_join stuff "sys_qoi" in the code or "system qoi" in the comment; technically that ought to only be called to combine two thread local QoIs and never to update System::qoi The return at the end of QoIContributions::join is redundant. Everything else looks good. In hindsight we shouldn't have left Vikram out-of-the-loop on this, but that design discussion would have taken hours if moved to mailing lists instead of face to face, and he did like the final result. Perhaps in the future we point a webcam at the office blackboard; we could put a semi-regular libMesh podcast on YouTube? ;-) --- Roy ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Libmesh-devel mailing list Libmesh-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libmesh-devel
