On Wed, Sep 19, 2012 at 2:04 PM, Roy Stogner <royst...@ices.utexas.edu>wrote:

>
> "by default, does nothing to maintain backward compatibility" should
> read "by default does nothing, to maintain backward compatibility".
> Sentences which reverse meaning based on comma placement are always
> amusing.
>

Ha!


> I wouldn't call the thread_join stuff "sys_qoi" in the code or "system
> qoi" in the comment; technically that ought to only be called to
> combine two thread local QoIs and never to update System::qoi
>

Derp, I wrote the comment before finishing the code and forgot to update
the comment. Thanks.

Patch with these changes committed in r6056.


> The return at the end of QoIContributions::join is redundant.
>

Forgot to do this before the previous commit. r6057.

In hindsight we shouldn't have left Vikram out-of-the-loop on this,

but that design discussion would have taken hours if moved to mailing lists
> instead of face to face, and he did like the final result.
> Perhaps in the future we point a webcam at the office blackboard; we
> could put a semi-regular libMesh podcast on YouTube?  ;-)
>

Ha! Internet fame awaits us...

Thanks for the comments!

Paul
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Libmesh-devel mailing list
Libmesh-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmesh-devel

Reply via email to