On Thu, Sep 20, 2012 at 1:08 PM, Roy Stogner <royst...@ices.utexas.edu>wrote:
> 1. Separate the "output" parts of the Context classes into a separate
> class. Right now we're passing around Context objects which contain
> output members (element residual/jacobian, local qoi, etc) along with
> input members (element solutions, FE data, etc), and because the
> former can't be const we're prevented from enforcing const-correctness
> on the latter. Leaving the inputs in the Context class and creating
> something like a DiffOutput/FEMOutput class (or better name t.b.d.)
> for everything mutable would fix that.
>
I like this idea a lot.
> 2. Put accessors around the raw member variables. Hopefully then
> future changes would be less likely to cause API breakage.
>
I'm, say, 30% of the way through this already (from FEAbstract work, etc.);
there was a devel thread on this - I'm not going rogue! Should I/we try to
finish before the next release?
> 3. Shorten some of the member names: "DiffContext::elem_solution"
> would become "DiffContext::solution", for example. Vikram just
> pointed out to me that it's somewhat odd to have a side_qoi() function
> assembling into a context.elem_qoi variable.
>
I'm all for better intuitive naming.
Paul
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://ad.doubleclick.net/clk;258768047;13503038;j?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
_______________________________________________
Libmesh-devel mailing list
Libmesh-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmesh-devel
