On Thu, 25 Oct 2012, Derek Gaston wrote:

Looks like contract() getting called from reinit() is the culprit:

Thanks!

>       Didn't it?  The old behavior was that there was no member variable,
> and the input bool went out of scope at the end of prepare_for_use(),
> so any setting passed in must have been forgotten afterwards.

Nope - I made a change a while back that would remember the value
you passed in to prepare_for_use() and use that value for all
subsequent calls to renumber_nodes_and_elements().  Check out
prepare_for_use() in r6180 for instance...

Ah - I'd randomly grabbed an older version to refresh my memory about
the old behavior.


Okay, then, here's my preference:

Change prepare_for_use(true) save that "true" permanently, in case
there are other codes like yours which depend on the old behavior.
Add a libmesh_deprecated() whenever it sees a "true" passed in to give
any such users fair warning that they should switch to the new
allow_renumbering() accessor.

Change UnstructuredMesh::copy_nodes_and_elements() to use the new
accessor for its prepare-without-renumbering, and afterward re-set the
copy's renumbering setting to match the original mesh.  (AFAIK this is
the only use of prepare_for_use(true) in library code)).

Leave things that way until the next official release.

Remove the argument from prepare_for_use right after the release.


Sound okay?
---
Roy
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________
Libmesh-devel mailing list
Libmesh-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmesh-devel

Reply via email to