On Sun, 28 Oct 2012, Paul T. Bauman wrote:
> Reviving this thread for the DiffContext accessor changes before the next > release. > Attached patch, I believe, provides accessors for everything that > should be protected in DiffContext. Wanted to get opinions before I > went through the rest of the library code. You could probably leave it to David or one of the other rbOOmit people to fix up the reduced_basis internal code. In any case it's not urgent that library code be *using* the accessors before the next release, it's just critical that the accessors be available (for forwards compatibility) and important that the examples be using them (to encourage new users to do so too). > I went through and updated, I believe, everything in fem_system_ex1 > and those changes are included in the patch. Thanks! > Aforementioned examples runs cleanly in dbg mode. OK with the names > I chose? Two possible objections I could see: > 1. The use of "get_" in the names Ugly, but hard to avoid, since we can't just use the original names alone for the accessors without breaking backwards compatibility. And it's in keeping with tradition; lots of other libMesh accessors begin with "get_". > 2. overloading get_elem_residual (for example) instead of doing > get_elem_subresidual. I'd rather have get_elem_subresidual etc. (less overloading sometimes means easier debugging and/or more ease adding optional default arguments if we need to later) but I'd defer to your preference. > Any other complaints? None here. Thanks, --- Roy ------------------------------------------------------------------------------ WINDOWS 8 is here. Millions of people. Your app in 30 days. Visit The Windows 8 Center at Sourceforge for all your go to resources. http://windows8center.sourceforge.net/ join-generation-app-and-make-money-coding-fast/ _______________________________________________ Libmesh-devel mailing list Libmesh-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libmesh-devel
