On Nov 20, 2012, at 5:23 PM, John Peterson <[email protected]> wrote:
> Ben, > > Attached is a (possible) fix for your previous fix to enable legacy > include paths (which still didn't work for me). > > I'm not sure this patch is totally safe because it refers to > $(top_srcdir), i.e. where the SVN checkout of libmesh resides. Well, at the top of Make.common we use top_srcdir if it is defined (i.e. within the automake environment), but then hackishly define it to @prefix@ when doing the install. So the Make.comon that exists in the install should be referring to the installed path, and then your patch is safe even when the original source tree is deleted. > Do we have to assume the user can delete their $(top_srcdir) at any > time and continue using the installed libmesh just fine? > > If so, I'm not sure what the best way to support legacy include paths would > be. Yes, that is the expected behavior, and your patch seems to do just fine. Note it will not work for someone who includes Make.common inside an automake project (thus reactivating top_srcdir), but that is ill-advised. -Ben ------------------------------------------------------------------------------ Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov _______________________________________________ Libmesh-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libmesh-devel
