https://bugs.documentfoundation.org/show_bug.cgi?id=161748
--- Comment #7 from Per99 <[email protected]> --- This is an update to this bug report: The old behaviour ("marching ants" animation) was still working in 7.6.7.2. The bug (the new behaviour: no "marching ants" animation (under a certain condition, see below)) was introduced in LibreOfficeDev_24.2.0.0.alpha1_Win_x86-64.msi A short summary first: In previous versions including 7.6.7.2 the "Show animations in Windows" in "Ease of Access" setting in WindowsOS is disregarded. Starting with LibreOfficeDev_24.2.0.0.alpha1_Win_x86-64.msi, this setting is suddenly used in LibreOffice (for just the "marching ants" animation). Starting with LibreOfficeDev_24.2.0.0.alpha1, one is able to turn *off* the "marching ants" animation in LO by using the expert setting "AnimationsEnabled", regardless of the state of "Show animations in Windows". However, the problem is, than one is not able to turn *on* the "marching ants" animation in LO by using the expert setting "AnimationsEnabled", regardless of the state of "Show animations in Windows". For visual impaired people (e.g. elderly people), or just having bad light conditions, the "marching ants" animation is really helpful. The "Show animations in Windows" in "Ease of Access" setting in WindowsOS turns on all animations in WindowsOS and makes a slow computer even slower. Suggestion: Enable the user to turn on "marching ants" animation by either setting the expert setting "AnimationsEnabled" in LO to "true" or to switch on "Show animations in Windows" in "Ease of Access" setting in WindowsOS. By this, the user is also able to turn off "marching ants" animation by setting the expert setting "AnimationsEnabled" in LO to "false" *and* to switch off "Show animations in Windows" in "Ease of Access" setting in WindowsOS. The default behaviour in previous versions including 7.6.7.2 was to only use the expert setting "AnimationsEnabled", which default value is “true”. Change request: Changing the line of code: https://opengrok.libreoffice.org/xref/core/sc/source/ui/view/overlayobject.cxx?r=9d68c794#41 mbAllowsAnimation = (officecfg::Office::Common::VCL::AnimationsEnabled::get() && !MiscSettings::GetUseReducedAnimation()); into: mbAllowsAnimation = (officecfg::Office::Common::VCL::AnimationsEnabled::get() || !MiscSettings::GetUseReducedAnimation()); Before it makes sense to change the code, how do you see the above suggestion and change request? Details for "Show animations in Windows" in "Ease of Access" setting in WindowsOS: (English: Windows OS -> Settings -> "Ease of Access" -> "Display" -> "Simplify and personalise Windows" -> "Show animations in Windows") (German: Windows OS -> Einstellungen -> "Erleichterte Bedienung" -> "Bildschirm" -> "Windows vereinfachen und personalisieren" -> "Animationen in Windows anzeigen") Further details: Searching in the code for "AnimationsEnabled" I found (among others): https://opengrok.libreoffice.org/xref/core/sc/source/ui/view/overlayobject.cxx?r=9d68c794#41 Searching in the code for "GetUseReducedAnimation" I found (among others): https://opengrok.libreoffice.org/xref/core/vcl/win/window/salframe.cxx?r=52a2c19f#3155 Searching the internet for "SystemParametersInfoW" I found (among others): https://stackoverflow.com/questions/64872405/change-ease-of-access-settings-via-windows-api-systemparametersinfo Where I found out how to change the return value of MiscSettings::GetUseReducedAnimation() Actual Results: In 7.6.7.2: The copied cells have a "marching ants" animation border as usual – regardless of the "Show animations in Windows" in "Ease of Access" setting in WindowsOS. In 24.2.4.2: The "marching ants" animation does not work if "Show animations in Windows" in "Ease of Access" setting in WindowsOS is switched off. The copied cells have a "sleeping ants" border (the same as the page break / print area). In 24.8.0.0.beta1+: The same result as in 24.2.4.2. In 7.6.7.2: The expert option "AnimationsEnabled" gets respected: "true" means "marching ants" animation border. "false" means "sleeping ants" border. In 24.2.4.2: The expert option "AnimationsEnabled" gets disregarded when "Show animations in Windows" in "Ease of Access" setting in WindowsOS is switched off. Both "true" as well as "false" means "sleeping ants" border. In 24.8.0.0.beta1+: The same result as in 24.2.4.2. Testing restarting in Safe Mode with hardware acceleration turned off produced the same result as above (with 24.2.4.2 and 24.8.0.0.beta1+) Expected Results: 1. The default behaviour should be that the copied cells have a "marching ants" animation as usual until and including 7.6.7.2 when the expert option "AnimationsEnabled" is “true” regardless of the "Show animations in Windows" in "Ease of Access" setting in WindowsOS. 2. The expert option "AnimationsEnabled" must get respected: "true" means "marching ants" animation border. "false" means "Sleeping ants" border when the "Show animations in Windows" in "Ease of Access" setting in WindowsOS is switched off. Details of my parallel installations of LO: (the were freshly installed with a new user profile in: UserInstallation=$ORIGIN/../Data/settings ) Version: 24.8.0.0.beta1+ (X86_64) / LibreOffice Community Build ID: dcaf9c147a1cfea268db49952171338555379794 CPU threads: 4; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: threaded ********************************************************** Version: 24.2.4.2 (X86_64) / LibreOffice Community Build ID: 51a6219feb6075d9a4c46691dcfe0cd9c4fff3c2 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: threaded Before it makes sense to change the code, how do you see the above suggestion and change request? I don’t know how to update this bug report, especially the Actual Results and Expected Results. Is there a way or do I have to clone this bug report? -- You are receiving this mail because: You are the assignee for the bug.
