https://bugs.documentfoundation.org/show_bug.cgi?id=145127

--- Comment #8 from Olly Betts <[email protected]> ---
It's reasonable that not all platforms are supported, but it'd help users (and
probably reduce the number of bug reports you'll need to mark as duplicates of
this) if this limitation was clearly documented.  Currently I can't see any
mention of this in the docs - perhaps
https://docs.libreoffice.org/libreofficekit.html would be a suitable place.

Also LibreOfficeKitInit.h actually contains conditionals which appear to be
there for macOS support, so anyone looking at the header would probably think
it was intended to be supported - e.g.:

    #ifdef __APPLE__                                                            
        #define TARGET_LIB        "lib" "sofficeapp" ".dylib"                   
        #define TARGET_MERGED_LIB "lib" "mergedlo" ".dylib"                     
    #else                                                                       
        #define TARGET_LIB        "lib" "sofficeapp" ".so"                      
        #define TARGET_MERGED_LIB "lib" "mergedlo" ".so"                        
    #endif                                                                      

It'd be more helpful to fail to compile with a clear error on macOS, e.g:

#ifdef __APPLE__
# error LibreOfficeKit not currently supported on macOS
#endif

Not sure if iOS defines __APPLE__ too, if so the condition would need to check
for that case.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to