https://bugs.documentfoundation.org/show_bug.cgi?id=145127
--- Comment #11 from Olly Betts <[email protected]> --- Thanks - I applied your patch to the loktest repo I used before (I just patched the copy of the headers already there as I don't have a LO git tree checked out to easily get hold of the latest versions). On macos that gives: In file included from loktest.cc:14: In file included from include/LibreOfficeKit/LibreOfficeKit.hxx:14: include/LibreOfficeKit/LibreOfficeKitInit.h:39:14: error: LibreOfficeKit is only supported on iOS #error LibreOfficeKit is only supported on iOS ^ include/LibreOfficeKit/LibreOfficeKitInit.h:204:44: error: use of undeclared identifier 'TARGET_LIB' imp_lib_size = partial_length + sizeof(TARGET_LIB) + sizeof(TARGET_MERGED_LIB) + 2; ^ include/LibreOfficeKit/LibreOfficeKitInit.h:204:65: error: use of undeclared identifier 'TARGET_MERGED_LIB' imp_lib_size = partial_length + sizeof(TARGET_LIB) + sizeof(TARGET_MERGED_LIB) + 2; ^ include/LibreOfficeKit/LibreOfficeKitInit.h:217:39: error: use of undeclared identifier 'TARGET_LIB' strncpy(imp_lib + partial_length, TARGET_LIB, imp_lib_size - partial_length); ^ include/LibreOfficeKit/LibreOfficeKitInit.h:237:43: error: use of undeclared identifier 'TARGET_MERGED_LIB' strncpy(imp_lib + partial_length, TARGET_MERGED_LIB, imp_lib_size - partial_length); ^ 5 errors generated. It seems unhelpful to trigger these additional errors - experienced C/C++ developers have probably learned to look at the first error first, but people just building the code may not and sometimes automated build systems just show you the tail of the log, so I tried a tweak: https://github.com/ojwb/loktest/commit/4f3aaf373de7c6178fe6ab9b63b04c01d86a5a11 With that I get: In file included from loktest.cc:14: In file included from include/LibreOfficeKit/LibreOfficeKit.hxx:14: include/LibreOfficeKit/LibreOfficeKitInit.h:36:14: error: LibreOfficeKit is only supported on iOS #error LibreOfficeKit is only supported on iOS ^ 1 error generated. The error message seems potentially misleading as LibreOfficeKit *is* supported on other platforms (Linux and Microsoft Windows for example). I'm not sure if there actually are any other Apple platforms other than iOS and macOS, but if not then "is not supported on macOS" seems clearer. If there are maybe "is not supported on Apple platforms other than iOS" or something less cumbersome. -- You are receiving this mail because: You are the assignee for the bug.
