https://bugs.documentfoundation.org/show_bug.cgi?id=146947
Buovjaga <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mentoring@documentfoundatio | |n.org Keywords| |difficultyMedium, easyHack, | |skillCpp, topicUI Status|REOPENED |NEW --- Comment #5 from Buovjaga <[email protected]> --- (In reply to Balázs Varga (allotropia) from comment #4) > (In reply to Buovjaga from comment #3) > > Balázs: I'm not seeing any toggle buttons in the decryption dialog. Tried > > with gtk3, kf6 and Windows. I even tested with the exact commit in Linux > > 25.8 bibisect repo. Please advise. > > > > Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community > > Build ID: 36b4609461d9daa7cfd9b00689f64d31717e5044 > > CPU threads: 8; OS: Linux 6.13; UI render: default; VCL: gtk3 > > Locale: fi-FI (fi_FI.UTF-8); UI: en-US > > Calc: CL threaded > > Ohh yeah, thanks for the notice. The plan for this implementation didn't > include the encryption/decryption dialog unfortunatelly, which is a > different UI file (cui/uiconfig/ui/password.ui) but almost the same as the > one in the patch: sfx2/uiconfig/ui/password.ui. So I didn't modify the > cui/uiconfig/ui/password.ui file. To add this toggle button to > encryption/decryption we just need to add basically the same things as in > the sfx2/uiconfig/ui/password.ui and in the sfx2/source/dialog/passwd.cxx > file. The other necessary bits (such as handling QT5, GTK3 etc..) were added > in the > https://git.libreoffice.org/core/commit/ > 6eb1a3c4b08f004c074dac41dee31bacb38216a5 patch. So basically just an easy > hack have left here. Unfortunatelly I can see now that this bugticket > related to only encryption/decryption dialog, so should not be closed yet. :) Aha. Well, this is a good example why bug report titles should not be copied to commit messages. Can you tell what we should do in the UI to see the toggle button currently? -- You are receiving this mail because: You are the assignee for the bug.
