https://bugs.documentfoundation.org/show_bug.cgi?id=146947

--- Comment #7 from Balázs Varga (allotropia) <[email protected]> ---
> Aha. Well, this is a good example why bug report titles should not be copied
> to commit messages.
> 
> Can you tell what we should do in the UI to see the toggle button currently?

Yeah, agree, it could be very confusing and misleading.

So two things need to be added:

First need to change the other password UI file: cui/ui/password.ui, basically
the same as it was changed in the patch with the sfx2/uiconfig/ui/password.ui
file. The password text fields need to be inserted in a horizontal two column
gtk box. The first column of the gtk box contains the original password
textfield and the second gtk column can contain the toggle button. Then need to
add the "eye" image to the toggle button, as it was added in the patch with the
sfx2/uiconfig/ui/password.ui. The images already added to our repo: see:
icon-themes/colibre/res/showpass.png and icon-themes/colibre/res/hidepass.png
files.

The second part is also basically the same what I did in the
sfx2/source/dialog/passwd.cxx file in the patch, but for this specific issue
need to be done in cui/source/dialogs/passwdomdlg.cxx

https://opengrok.libreoffice.org/xref/core/cui/source/dialogs/passwdomdlg.cxx?r=ecf6f6f25663e81ebf18589b895a22bc5b6ffbab#143

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to