https://bugs.freedesktop.org/show_bug.cgi?id=46990
Michael Meeks <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |[email protected] Ever confirmed|0 |1 --- Comment #4 from Michael Meeks <[email protected]> --- nice work :-) so - a few requests; could you change the patch to: static bool is_xfce_desktop( Display* pDisplay ) to have a single return statement in the body ? Also - can you test this with an 'unset DESKTOP_SESSION' ? - it's not obvious that the OUString constructor will cope with NULL nicely. It's entirely possible that we want to extract and convert that DESKTOP_SESSION into an OString just once to avoid a number of getenv() calls which just waste time (and the malloc/free of constructing an OString). Now I read that code more I'm a bit annoyed that we do all this X property / heavy lifting for TDE un-conditionally in there - IMHO it'd be good to disable that for performance if the backend is not compiled in :-) It'd also be nice to avoid doing the KDE / X property foo as well for performance. At least, until we have no env. vars to give us security. This chunk: + else if ( desktop == DESKTOP_XFCE ) + pList = pStandardFallbackList; + else if ( desktop == DESKTOP_MATE ) + pList = pStandardFallbackList; Would look nicer with a pair of || clauses in the if( GNOME ) above I think. Any chance of some improvements like that ? :-) And thanks for contributing ! BTW. it's preferable to send patches to the developer list with [PATCH] in the Subject I think, rather than attaching in bugzilla; please do CC me too ... -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
