https://bugs.freedesktop.org/show_bug.cgi?id=46990

[email protected] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81821|0                           |1
        is obsolete|                            |

--- Comment #5 from [email protected] ---
Created attachment 81894
  --> https://bugs.freedesktop.org/attachment.cgi?id=81894&action=edit
add MATE and XFCE to standard fallback list - try2

Thanks for your notes, Michael.

About your requests:

I reworked the is_xfce_desktop() and is_mate_desktop() with return, and added
desktop == DESKTOP_XFCE and desktop == DESKTOP_MATE to desktop == DESKTOP_GNOME
with an || operator.

unset DESKTOP_SESSION: why? If any user log in to any desktop environment, this
environment variable automatically gets a value.

Unconditional TDE check:
- desktopdetector.cxx, static int TDEVersion( Display* pDisplay ): if I use a
condition for TDE, why not apply a condition for KDE and KDE4? Same in
DESKTOP_DETECTOR_PUBLIC DesktopType get_desktop_environment(), and const char*
pPlugin[] = { "gtk3", "gtk", "kde4", "kde", "tde", "gen", 0 }; in salplug.cxx.
- salplug.cxx: static const char* pTDEFallbackList[] - can you imagine a TDE
environment / fallback without TDE? :)
So I don't know...

I'm not an expert in LO code and programming, my patch just a quick hack, which
works for me (I use ~2 months ago).

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to