https://bugs.documentfoundation.org/show_bug.cgi?id=170685
Bug ID: 170685
Summary: Replace uses of ScDocument::GetValue (and friends)
taking ScAddress with respective functions taking
three numbers
Product: LibreOffice
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Keywords: difficultyBeginner, easyHack, skillCpp
Severity: normal
Priority: medium
Component: Calc
Assignee: [email protected]
Reporter: [email protected]
Especially in Calc's unit tests, there are lots of calls like
pDoc->GetValue(ScAddress(1, 0, 0));
pDoc->SetValue(ScAddress(1, 0, 0), 5.0);
pDoc->GetString(ScAddress(1, 0, 0));
pDoc->SetString(ScAddress(1, 0, 0), u"foo"_ustr);
and so on.
But explicit use of ScAddress is only a noise; these can be
pDoc->GetValue(1, 0, 0);
pDoc->SetValue(1, 0, 0, 5.0);
pDoc->GetString(1, 0, 0);
pDoc->SetString(1, 0, 0, u"foo"_ustr);
... and actually, the variants taking ScAddress, internally call the latter
variants.
This easyhack is for replacing the former with the latter.
--
You are receiving this mail because:
You are the assignee for the bug.
