https://bugs.documentfoundation.org/show_bug.cgi?id=173608

Neil Roberts <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
           Keywords|                            |bisected

--- Comment #2 from Neil Roberts <[email protected]> ---
Bibisected to the commit below.

Judging from the commit message it looks like this change in behaviour was
intentional. It does seem very surprising to change existing behaviour like
that though. I wonder if it stems from a misunderstanding of how relative sheet
references are supposed to work. I don’t have enough experience with
spreadsheets to judge.

commit 5cefed66bccab3757793686e9402b2faf37fcb8a
Author: Tomaž Vajngerl <[email protected]>
Date:   Sat Feb 28 00:22:24 2026 +0900

    sc: Fix backward reference when copying a sheet

    When extending the test for Overwrite content I also added a case to
    check a backwards tab reference (referencing a tab that precedes the
    current one). This extends the test for CopyTab, but surprisingly it
    failed.

    In a copied tab, it is needed to adjust the relative tab references,
    as they still need to point to the same tab, but because the reference
    is relative, the actual value needs to change (for example from index
    -1 to -2). This mechanism was missing.

    This combines the work for OverwriteContent and extends the method
    AdjustRelativeTabRefs so it can be used for both.

    This also adds a new sc::CopyTabMode enum to denote if we are adjusting
    a tab that is inserted or an existing one.

    Tests were adjusted with the relevant use cases.

    Change-Id: Ie32d0ceac34525ccaf13aed8fb9630ae42d4225e
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200674

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to