https://bugs.documentfoundation.org/show_bug.cgi?id=174081
Julien Nabet <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] | |g, [email protected] --- Comment #1 from Julien Nabet <[email protected]> --- Christian: I took a look at Collabora to see what they've done about this part and noticed this patch: 7cbb9be91dfad98d051f262ffc7c792542be0075 shell, installer, scp2: drop Windows-MSI / SharePoint / quickstart / ActiveX CODA-W targets the Microsoft Store exclusively, so the classic Win-MSI build target, the SharePoint OpenDocuments ActiveX shim, the legacy ActiveX control for embedding soffice into Win32 hosts, and the systray quickstart launcher are dead weight. Strip: - spsupp/ SharePoint shim, per-machine ProgID, unavailable to MSIX - regsvrex.exe, lngconvex.exe MSI build-time tools - setup_native/source/win32/customactions/ MSI custom-action DLLs (instooofiltmsi, qslnkmsi, sdqsmsi, regactivex, reg_dlls, reg4allmsdoc, sellangmsi, shlxtmsi, sn_tools, seterror) - engine/scp2/source/{winexplorerext, activex,quickstart,spsupp}/ scp2 modules + matching InstallModule_*.mk - InstallModule_windows.mk and every registryitem_*.scp ~5900 lines of HKCR/HKLM entries that AppxManifest.xml FileTypeAssociations replace - extensions/source/activex/ legacy MS ActiveX control - engine/desktop/Executable_quickstart.mk + QuickStart/ + sfx2 ShutdownIcon + --quickstart cmdline + Tools->Options + com.sun.star.office.Quickstart UNO ~1500 lines; modern Win10/11 prelaunch is uap5:StartupTask - engine/solenv/bin/modules/installer/ windows/ 25 .pm files, ~12K lines of Win-MSI Perl plus every 'use installer::windows::*' and 'if (\$iswindowsbuild)' branch in the surviving support modules - instsetoo_native/inc_*/windows/ MSI .idt templates, ulf sources, banner / icon assets - --enable-wix, --enable-silent-msi, msi from --with-package-format, ENABLE_QUICKSTART_APPLET, WINDOWS_SDK_WILANGID configure.ac, config_host.mk.in - 131 translation res.po directories under .../shell/source/win32/ shlxthandler/ and similar Of course LO is available via MSI so the initial assumption "CODA-W targets the Microsoft Store exclusively..." doesn't apply but wonder if there are stuff that could be dropped. Anyway if we focus on the bugtracker, should we just change the description here on line 20 of scp2/source/winexplorerext/module_winexplorerext.ulf 19 [STR_NAME_MODULE_OPTIONAL_WINDOWS_EXPLORER_EXTENSIONS] 20 en-US = "Windows Explorer Extension" 21 22 [STR_DESC_MODULE_OPTIONAL_WINDOWS_EXPLORER_EXTENSIONS] 23 en-US = "Enables the Microsoft File Explorer to show information about %PRODUCTNAME documents, such as thumbnail previews, and perform full-text search." 24 or should we also modify more and it if we follow that lead, it means renaming variables, paths, etc. just an example: git grep -n winexplorerext Repository.mk:759:$(eval $(call gb_Helper_register_libraries_for_install,PLAINLIBS_OOO,winexplorerextbinarytable, \ Repository.mk:763:$(eval $(call gb_Helper_register_libraries_for_install,PLAINLIBS_SHLXTHDL,winexplorerext, \ scp2/AutoInstall.mk:47:$(eval $(call gb_AutoInstall_add_module,winexplorerextbinarytable,LIBO_LIB_FILE_BINARYTABLE)) scp2/AutoInstall.mk:48:$(eval $(call gb_AutoInstall_add_module,winexplorerext,SHLXTHDL_LIB_FILE)) scp2/InstallModule_winexplorerext.mk:10:$(eval $(call gb_InstallModule_InstallModule,scp2/winexplorerext)) scp2/InstallModule_winexplorerext.mk:12:$(eval $(call gb_InstallModule_use_auto_install_libs,scp2/winexplorerext,\ scp2/InstallModule_winexplorerext.mk:13: winexplorerextbinarytable \ scp2/InstallModule_winexplorerext.mk:14: winexplorerext \ scp2/InstallModule_winexplorerext.mk:17:$(eval $(call gb_InstallModule_add_scpfiles,scp2/winexplorerext,\ scp2/InstallModule_winexplorerext.mk:18: scp2/source/winexplorerext/file_winexplorerext \ scp2/InstallModule_winexplorerext.mk:19: scp2/source/winexplorerext/registryitem_winexplorerext \ scp2/InstallModule_winexplorerext.mk:22:$(eval $(call gb_InstallModule_add_localized_scpfiles,scp2/winexplorerext,\ scp2/InstallModule_winexplorerext.mk:23: scp2/source/winexplorerext/module_winexplorerext \ scp2/InstallScript_setup_osl.mk:30: scp2/winexplorerext \ scp2/Module_scp2.mk:38: InstallModule_winexplorerext \ scp2/source/winexplorerext/module_winexplorerext.scp:21:#include "AutoInstall/winexplorerextbinarytable" scp2/source/winexplorerext/module_winexplorerext.scp:22:#include "AutoInstall/winexplorerext" scp2/source/winexplorerext/module_winexplorerext.scp:30: Files = (auto_winexplorerextbinarytable_ALL, scp2/source/winexplorerext/module_winexplorerext.scp:31: auto_winexplorerext_ALL, solenv/bin/modules/installer/windows/component.pm:253: if ( $componentname =~ m/winexplorerext_x64/ ) { $attributes |= 256; } solenv/gbuild/extensions/post_PackageInfo.mk:25: winexplorerextbinarytable \ should all "winexplorer..." be renamed "fileexplorer" (the double "e" may also be error prone) -- You are receiving this mail because: You are the assignee for the bug.
