https://bugs.documentfoundation.org/show_bug.cgi?id=95416
Eike Rathke <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bjoern.michaelsen@canonical
| |.com, [email protected],
| |markus.mohrhard@googlemail.
| |com,
| |[email protected]
| |, [email protected],
| |[email protected]
--- Comment #32 from Eike Rathke <[email protected]> ---
ARGH! Can we please be VERY SENSIBLE about this? It leads to blindly moving
headers into a module's global inc/ directory, making them available to each
and every source file of that module effectively destroying the separation of
view,core,filter even further. Examples of such bad moves are
https://cgit.freedesktop.org/libreoffice/core/commit/?id=a0f6374670f67646e802aef45d927a8746b2ae12
moving Calc ViewData around and the just pending
https://gerrit.libreoffice.org/34827 that even wanted to move ScDocShell which
would be an invitation to use it about ~everywhere.
I rather prefer having some sporadic
#include "../../ui/inc/xxx.hxx"
if really necessary than letting run this loose. Specifically UI view related
classes are not to be offered for general use even if now and then they may be
needed by filter code.
I also consider deciding how to solve things by no means an EasyHack in all
cases unless we don't care about model separation anymore.
Or am I just on the wrong track and everything is fine?
--
You are receiving this mail because:
You are the assignee for the bug._______________________________________________
Libreoffice-bugs mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
