https://bugs.documentfoundation.org/show_bug.cgi?id=128029
Oliver Brinzing <oliver.brinz...@gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |vmik...@collabora.com
Keywords|bibisectRequest |bibisected, bisected
--- Comment #6 from Oliver Brinzing <oliver.brinz...@gmx.de> ---
seems to have started with:
https://gerrit.libreoffice.org/plugins/gitiles/core/+/29d4ecf32392bc94ab0ba9e73fd79eba65c23fdb
commit 29d4ecf32392bc94ab0ba9e73fd79eba65c23fdb [log]
author Miklos Vajna <vmik...@collabora.co.uk>
Thu Mar 29 18:27:13 2018 +0200
committer Miklos Vajna <vmik...@collabora.co.uk>
Thu Mar 29 19:28:11 2018 +0200
tree a6f88f801f0857063820b7f39a894f10d64fee7b
parent d7a8fa7adf2b2b098a1e38cd7002c928d015b489 [diff]
tdf#115574 sot: fix Excel -> Writer paste
Reported problem is that nothing happens for paste. Direct cause is that
BITMAP is selected as the format, and Excel advertises BITMAP, but when
we try to import that, it fails. There are 3 interesting commits in the
recent history for this topic:
- commit c47db038f98aaf7aec3cbe57c4e5683591afa23e (fdo#52547 SOT: Prefer
embedding image data to embedding linked image., 2014-02-07) was a
bugfix due to newer firefox
- commit 538c13f3d1756f2d105115f64ab1bc0b7426eebc (fdo#78801 fdo#52547
Paste preference is image, then html, then text., 2014-05-28) was a
regression fix from the previous fix
- commit a96a7ce51aa98fb9ee97ea3803e2b7e648611008 (fdo#81835 Don't
prefer GDI Metafiles to RTF/HTML, 2014-08-05), was a regression fix
from the previous fixes
Going back to the original state shows that the Excel -> Writer use-case
used to be RTF.
Restore the old Excel -> Writer (RTF) behavior by:
- going back to the original state, ignoring the enum class conversions
- re-fix fdo#52547: prefer bitmap over html, but leave everything else
unchanged
- fdo#78801 needs no fix in this case
- fdo#81835 needs no fix in this case
- tdf#115574 selects RTF -> table shows up
After all these complications, the actual fix is surprisingly simple.
/cygdrive/d/sources/bibisect/bibisect-win32-6.1
$ git bisect good
f4cfb9598988ab03f10832b93b89c7249e66f14b is the first bad commit
commit f4cfb9598988ab03f10832b93b89c7249e66f14b
Author: Norbert Thiebaud <nthieb...@gmail.com>
Date: Sat Mar 31 01:52:10 2018 -0700
source sha:29d4ecf32392bc94ab0ba9e73fd79eba65c23fdb
source sha:29d4ecf32392bc94ab0ba9e73fd79eba65c23fdb
:040000 040000 ee603774f375ab42a016c45f73a4ba09b65c73c2
e160bac95b7dfbe9bd6371ee64f20be386e64d97 M instdir
/cygdrive/d/sources/bibisect/bibisect-win32-6.1
$ git bisect log
# bad: [75d131082ce51ed5a898d97bdc2b7a9fe5ddb340] source
sha:5b3765f4d881e7ddefd0c4aad6886a46f000b4fc
# good: [29d08f54c2f71ffee4fe12dbb24c5f5cbedecfd2] source
sha:6eeac3539ea4cac32d126c5e24141f262eb5a4d9
git bisect start 'master' 'oldest'
# good: [6227e15df9be101688e37cd891817cd858b49e03] source
sha:b8b7f8a8f8d97088181d287bb75e74facece16c6
git bisect good 6227e15df9be101688e37cd891817cd858b49e03
# bad: [50b236fe0d359b9d5cc9998d2e72009a90a11d08] source
sha:b6025e6cffe2024fefebd161ea739188b4b4fdaf
git bisect bad 50b236fe0d359b9d5cc9998d2e72009a90a11d08
# bad: [f90bd08b3698a799ce313bacc87521d2a5439e45] source
sha:352a99b8cc3ac5b0bb579b9f1dd528711d1cd27a
git bisect bad f90bd08b3698a799ce313bacc87521d2a5439e45
# good: [abb031939baa8841c549f558c340aa298924f773] source
sha:5204a5145d8232ea0650144fb4756c38303ef06e
git bisect good abb031939baa8841c549f558c340aa298924f773
# good: [0fd02cafc7f2ace56c1a880d71442525b316da5e] source
sha:449d416335802b23cf0f8f4725042f92138019cd
git bisect good 0fd02cafc7f2ace56c1a880d71442525b316da5e
# bad: [7d0423fd570da9c907e472319764bae46074a0a9] source
sha:7260cd5381ce5511fd761cd4ca012fcb62fe3c17
git bisect bad 7d0423fd570da9c907e472319764bae46074a0a9
# good: [bf8a0a00955720312c42498e4dfa000d6b99b0a3] source
sha:6a189b2ac72d5fb83199bdb09e41f7d088440cc9
git bisect good bf8a0a00955720312c42498e4dfa000d6b99b0a3
# good: [f53ca9859be58b596f6077408c89ee82d85e9261] source
sha:484fe43b5e9f3696d26b8c0452aab6fd14e10772
git bisect good f53ca9859be58b596f6077408c89ee82d85e9261
# good: [74067fb4f5b23a02e27376f56bb463e111231c73] source
sha:f62fcab7f16a2c6abbc37a0d83145e9ded3ad6e3
git bisect good 74067fb4f5b23a02e27376f56bb463e111231c73
# good: [f9a068e6b90ae0bb85c42dfc72f04102ecba9d9b] source
sha:596fd41b9b19e28bab0c84e3821f79cb5d468f24
git bisect good f9a068e6b90ae0bb85c42dfc72f04102ecba9d9b
# good: [64fa0e5b136d8a3e717203844cd0b8a158b3e12a] source
sha:da4121ee730a3c4c95bfc717c76ec016e6861737
git bisect good 64fa0e5b136d8a3e717203844cd0b8a158b3e12a
# bad: [f4cfb9598988ab03f10832b93b89c7249e66f14b] source
sha:29d4ecf32392bc94ab0ba9e73fd79eba65c23fdb
git bisect bad f4cfb9598988ab03f10832b93b89c7249e66f14b
# good: [75b3f9f6f949625b5f5ac77bc7bd7df99ceaba5f] source
sha:d7a8fa7adf2b2b098a1e38cd7002c928d015b489
git bisect good 75b3f9f6f949625b5f5ac77bc7bd7df99ceaba5f
# first bad commit: [f4cfb9598988ab03f10832b93b89c7249e66f14b] source
sha:29d4ecf32392bc94ab0ba9e73fd79eba65c23fdb
--
You are receiving this mail because:
You are the assignee for the bug._______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
