https://bugs.freedesktop.org/show_bug.cgi?id=57061

--- Comment #79 from Petr Mladek <[email protected]> ---
Grr, i have this "TAB" + "Enter" behavior in bugzilla. Let me continue:

        + I am going to put the fix for the online checking after some
investigation


3. Many changes in menu entries are not migrated (comment 71 by Harald)

     + it seems that the menu entries are filtered by a pretty old code added
by
       
http://cgit.freedesktop.org/libreoffice/core/commit/?id=97e96b230c86d10cb31793d3737c7d1d97041dfb

     + IMHO, the problem is that the code does not know if the menu entries
        were added/removed/renamed by the user or by the new version.
        It has to guess and it seems to be using the following approach:

           a) it ignores renamed entries because they might be renamed by the
new version;
               It helps to be compatible with help and tutorials; By other
words, it
                always enforces the name from the new version;

                This explains the non-renamed menu items - problem 5, 13, 16
from comment 71.


            d) It ignore moved entries because the move could be caused by new
version.
                It again helps to be compatible with help and tutorials. The
only exception are
                menu entries added by the user, see below. By other words, it
resets
                the order according to the new menu. It keeps the entries that
are not longer
                in the new menu on the location where they were before.

                This explains the non-migrated moves - problems 1, 2, 6, 12, 14

           b) It tries to do not lose any user added entry. It keep all entries
from the old user
               menu that are not in the new menu.

              This explains the forgotten menu entry - problem 18 from comment
71.


           c) It tries to do not loose any new menu entry from the new
application. It keep all entries from 
               the new menu that are not in the old user menu.

               This explains the non-deleted entries - problems 4, 8, 16, 17
from comment 71.
                Note that the two zoom items are caused by non-deleted old
"Zoom" entry.

   So, it is explained. The questions is what to do with it. I do not see any
easy solution. The current
   logic sounds reasonable. If we want to solve it properly, we would need to
store information about
   all menu changes between all old OOo and LO release and use it in the update
logic. This would 
   be a real hard hack and I am not sure if it is worth the effort. It would be
actually needed even
   for update between minor versions that modify menu entries as well.

   If we want to better solve the menu migration, I would open separate
enhancement bug for it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to