https://bugs.documentfoundation.org/show_bug.cgi?id=155946

--- Comment #2 from Eyal Rozenberg <[email protected]> ---
(In reply to Eike Rathke from comment #1)
> Not necessarily. 

Not necessarily what?

>If standard text is pasted from the system clipboard then
> offering Tab is actually a good choice because any text can contain all
> other separators without them being actually separators, specifically comma.

If there are no tabs, then offering a tab is obviously not a good choice. But
other than that, and like I said - any reasonable heuristic is fine by me.

> Furthermore, if cells are copied to clipboard and pasted as text-only they
> will be separated by Tab, so at least in that case it's the only sensible
> choice. 

But that's a case where the pasted text already has tabs. The point of this
issue is to not to assume this is the case always - which it isn't. 

> Also note that the last choice is remembered, so whether you
> actually get Tab offered depends on your previous action.

Well, yes, but the memory becomes irrelevant if the pasted text doesn't use
that separator.

> For the first time
> of dialog usage we even already try to determine a separator in the context
> of ending a quoted field. "apply some simple heuristic" is wishful thinking,
> but what exactly should that "simple" be? The "if it has no
> [...separator...] then don't offer it" doesn't help either, because a
> checked separator that isn't used in data has no effect on the import, so
> not offering it is just cosmetic.

I'm not sure I follow. Of course it helps if the default choice in the dialog
is of a separator that actually appears in the text rather than one which
doesn't. 

Give the memory we have of the user's last choice, the simple heuristic might
be: "User's last choice, unless the text doesn't have that separator (or even -
unless the first line doesn't have), in which case the first separator which
appears on the first line."

That's pretty simple. Feel free to suggest something else.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to