On Thu, 2015-11-26 at 19:03 +0100, Markus Mohrhard wrote:
> please add a performance test that ensures that future refactorings
> won't regress here. In general any patch claiming performance
> improvements should be accompanied by a performance test to make sure
Great idea =) and easy to do too; Kendy ?
> Related to the code I wanted to mention that the getenv calls should
> be cached in a static variable as they might become expensive when
I was concerned by that too =) I believe the plan is to bin those; but
yes - good to check the perf tests for sure; and to have some nice
before/after step here.
ATB,
Michael.
--
michael.me...@collabora.com <><, Pseudo Engineer, itinerant idiot
_______________________________________________
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
