Hi Michael, Cedric,
Thank you for everything.
(11/11/19 7:17), Michael Stahl wrote:
hi Tomofumi,
thank you for your patch; i have pushed it, but not as a fix to the bug
40831 :)
(--)
i am currently not sure if your patch is the right fix; i would assume
that the cursor that points to the removed node should have been moved
away from it by ... something.
really the problem here is that we cannot store the position as a bunch
of integers or a non-relocatable SwPosition here where nodes may
actually be deleted; we need a cursor that is automatically corrected by
PamCorrAbs/Rel.
this is fixed by using SwUnoCrsr instead:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=82a716f29cc252740c80556f72f9d9e602877918
I think much better of this fixthan mine,too.
Well, Tomofumi's patch looks like on more safety check in that couldn't
harm. I'ld go for pushing his (second) patch.
indeed, our users would probably appreciate it if writer does not crash
when this kind of problem occurs, so i have pushed Tomofumi's patch to
prevent this from happening:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=af0333e5865ecd184270af3211880d6d02307c31
but then i added assertions to detect the problem, so that this
work-around will not cover it up completely and hopefully developers pay
attention:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=9de2110e5bed17fcc6050bfaa669df45f0c1eb44
I also agree with.
Thanks again.
Best regards,
--
Tomofumi Yagi
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
