Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
4 new defect(s) introduced to LibreOffice found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)
** CID 1655285: Concurrent data access violations (MISSING_LOCK)
/sd/source/console/PresenterSlideShowView.cxx: 187 in
sdext::presenter::PresenterSlideShowView::disposing(std::unique_lock<std::mutex>
&)()
_____________________________________________________________________________________________
*** CID 1655285: Concurrent data access violations (MISSING_LOCK)
/sd/source/console/PresenterSlideShowView.cxx: 187 in
sdext::presenter::PresenterSlideShowView::disposing(std::unique_lock<std::mutex>
&)()
181 // Tell all listeners that we are disposed.
182 lang::EventObject aEvent;
183 aEvent.Source = static_cast<XWeak*>(this);
184
185 assert(rLock.mutex() == &m_aMutex);
186 maMouseListeners.disposeAndClear(rLock, aEvent);
>>> CID 1655285: Concurrent data access violations (MISSING_LOCK)
>>> Accessing "this->maMouseMotionListeners" without holding lock
>>> "comphelper::UnoImplBase.m_aMutex". Elsewhere,
>>> "sdext::presenter::PresenterSlideShowView.maMouseMotionListeners" is
>>> written to with "UnoImplBase.m_aMutex" held 2 out of 2 times.
187 maMouseMotionListeners.disposeAndClear(rLock, aEvent);
188 maPaintListeners.disposeAndClear(rLock, aEvent);
189 maModifyListeners.disposeAndClear(rLock, aEvent);
190
191 // Do this for
192 // XPaintListener,
XModifyListener,XMouseListener,XMouseMotionListener,XWindowListener?
** CID 1655284: Concurrent data access violations (MISSING_LOCK)
/sd/source/console/PresenterSlideShowView.cxx: 189 in
sdext::presenter::PresenterSlideShowView::disposing(std::unique_lock<std::mutex>
&)()
_____________________________________________________________________________________________
*** CID 1655284: Concurrent data access violations (MISSING_LOCK)
/sd/source/console/PresenterSlideShowView.cxx: 189 in
sdext::presenter::PresenterSlideShowView::disposing(std::unique_lock<std::mutex>
&)()
183 aEvent.Source = static_cast<XWeak*>(this);
184
185 assert(rLock.mutex() == &m_aMutex);
186 maMouseListeners.disposeAndClear(rLock, aEvent);
187 maMouseMotionListeners.disposeAndClear(rLock, aEvent);
188 maPaintListeners.disposeAndClear(rLock, aEvent);
>>> CID 1655284: Concurrent data access violations (MISSING_LOCK)
>>> Accessing "this->maModifyListeners" without holding lock
>>> "comphelper::UnoImplBase.m_aMutex". Elsewhere,
>>> "sdext::presenter::PresenterSlideShowView.maModifyListeners" is written to
>>> with "UnoImplBase.m_aMutex" held 2 out of 2 times.
189 maModifyListeners.disposeAndClear(rLock, aEvent);
190
191 // Do this for
192 // XPaintListener,
XModifyListener,XMouseListener,XMouseMotionListener,XWindowListener?
193
194 if (mxWindow.is())
** CID 1655283: Concurrent data access violations (MISSING_LOCK)
/sd/source/console/PresenterSlideShowView.cxx: 186 in
sdext::presenter::PresenterSlideShowView::disposing(std::unique_lock<std::mutex>
&)()
_____________________________________________________________________________________________
*** CID 1655283: Concurrent data access violations (MISSING_LOCK)
/sd/source/console/PresenterSlideShowView.cxx: 186 in
sdext::presenter::PresenterSlideShowView::disposing(std::unique_lock<std::mutex>
&)()
180 {
181 // Tell all listeners that we are disposed.
182 lang::EventObject aEvent;
183 aEvent.Source = static_cast<XWeak*>(this);
184
185 assert(rLock.mutex() == &m_aMutex);
>>> CID 1655283: Concurrent data access violations (MISSING_LOCK)
>>> Accessing "this->maMouseListeners" without holding lock
>>> "comphelper::UnoImplBase.m_aMutex". Elsewhere,
>>> "sdext::presenter::PresenterSlideShowView.maMouseListeners" is written to
>>> with "UnoImplBase.m_aMutex" held 2 out of 2 times.
186 maMouseListeners.disposeAndClear(rLock, aEvent);
187 maMouseMotionListeners.disposeAndClear(rLock, aEvent);
188 maPaintListeners.disposeAndClear(rLock, aEvent);
189 maModifyListeners.disposeAndClear(rLock, aEvent);
190
191 // Do this for
** CID 1655282: Concurrent data access violations (MISSING_LOCK)
/sd/source/console/PresenterSlideShowView.cxx: 188 in
sdext::presenter::PresenterSlideShowView::disposing(std::unique_lock<std::mutex>
&)()
_____________________________________________________________________________________________
*** CID 1655282: Concurrent data access violations (MISSING_LOCK)
/sd/source/console/PresenterSlideShowView.cxx: 188 in
sdext::presenter::PresenterSlideShowView::disposing(std::unique_lock<std::mutex>
&)()
182 lang::EventObject aEvent;
183 aEvent.Source = static_cast<XWeak*>(this);
184
185 assert(rLock.mutex() == &m_aMutex);
186 maMouseListeners.disposeAndClear(rLock, aEvent);
187 maMouseMotionListeners.disposeAndClear(rLock, aEvent);
>>> CID 1655282: Concurrent data access violations (MISSING_LOCK)
>>> Accessing "this->maPaintListeners" without holding lock
>>> "comphelper::UnoImplBase.m_aMutex". Elsewhere,
>>> "sdext::presenter::PresenterSlideShowView.maPaintListeners" is written to
>>> with "UnoImplBase.m_aMutex" held 2 out of 2 times.
188 maPaintListeners.disposeAndClear(rLock, aEvent);
189 maModifyListeners.disposeAndClear(rLock, aEvent);
190
191 // Do this for
192 // XPaintListener,
XModifyListener,XMouseListener,XMouseMotionListener,XWindowListener?
193
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://scan.coverity.com/projects/libreoffice?tab=overview
