Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
3 new defect(s) introduced to LibreOffice found with Coverity Scan.
8 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1659061: Uninitialized members (UNINIT_CTOR)
/sw/source/uibase/uiview/view2.cxx: 1316 in
SwView::Execute(SfxRequest &)::[lambda(unsigned int) (instance
1)]::lambda(const [lambda(unsigned int) (instance 1)]&)()
_____________________________________________________________________________________________
*** CID 1659061: Uninitialized members (UNINIT_CTOR)
/sw/source/uibase/uiview/view2.cxx: 1316 in
SwView::Execute(SfxRequest &)::[lambda(unsigned int) (instance
1)]::lambda(const [lambda(unsigned int) (instance 1)]&)()
1310 std::shared_ptr<SfxRequest> xRequest =
std::make_shared<SfxRequest>(rReq);
1311 rReq.Ignore();
1312
1313 auto xDialog = std::make_shared<svx::GotoPageDlg>(
1314 GetViewFrame().GetFrameWeld(),
SwResId(STR_GOTO_PAGE_DLG_TITLE),
1315 SwResId(ST_PGE) + ":", nPhyPage,
GetWrtShell().GetPageCnt());
>>> CID 1659061: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "this" is not initialized in this constructor
>>> nor in any functions that it calls.
1316 weld::DialogController::runAsync(xDialog, [this, xDialog,
xRequest](sal_uInt32 nResult) {
1317 if (nResult == RET_OK)
1318
GetWrtShell().GotoPage(xDialog->GetPageSelection(), true);
1319
1320 xRequest->Done();
1321 });
** CID 1659060: Uninitialized members (UNINIT_CTOR)
/sw/source/uibase/uiview/view2.cxx: 1316 in
SwView::Execute(SfxRequest &)::[lambda(unsigned int) (instance
1)]::lambda([lambda(unsigned int) (instance 1)]&&)()
_____________________________________________________________________________________________
*** CID 1659060: Uninitialized members (UNINIT_CTOR)
/sw/source/uibase/uiview/view2.cxx: 1316 in
SwView::Execute(SfxRequest &)::[lambda(unsigned int) (instance
1)]::lambda([lambda(unsigned int) (instance 1)]&&)()
1310 std::shared_ptr<SfxRequest> xRequest =
std::make_shared<SfxRequest>(rReq);
1311 rReq.Ignore();
1312
1313 auto xDialog = std::make_shared<svx::GotoPageDlg>(
1314 GetViewFrame().GetFrameWeld(),
SwResId(STR_GOTO_PAGE_DLG_TITLE),
1315 SwResId(ST_PGE) + ":", nPhyPage,
GetWrtShell().GetPageCnt());
>>> CID 1659060: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "this" is not initialized in this constructor
>>> nor in any functions that it calls.
1316 weld::DialogController::runAsync(xDialog, [this, xDialog,
xRequest](sal_uInt32 nResult) {
1317 if (nResult == RET_OK)
1318
GetWrtShell().GotoPage(xDialog->GetPageSelection(), true);
1319
1320 xRequest->Done();
1321 });
** CID 1659059: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sw/source/uibase/uiview/view2.cxx: 1316 in
SwView::Execute(SfxRequest &)()
_____________________________________________________________________________________________
*** CID 1659059: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sw/source/uibase/uiview/view2.cxx: 1316 in
SwView::Execute(SfxRequest &)()
1310 std::shared_ptr<SfxRequest> xRequest =
std::make_shared<SfxRequest>(rReq);
1311 rReq.Ignore();
1312
1313 auto xDialog = std::make_shared<svx::GotoPageDlg>(
1314 GetViewFrame().GetFrameWeld(),
SwResId(STR_GOTO_PAGE_DLG_TITLE),
1315 SwResId(ST_PGE) + ":", nPhyPage,
GetWrtShell().GetPageCnt());
>>> CID 1659059: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "xRequest" is copied in call to copy constructor
>>> "std::shared_ptr<SfxRequest>", when it could be moved instead.
1316 weld::DialogController::runAsync(xDialog, [this, xDialog,
xRequest](sal_uInt32 nResult) {
1317 if (nResult == RET_OK)
1318
GetWrtShell().GotoPage(xDialog->GetPageSelection(), true);
1319
1320 xRequest->Done();
1321 });
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://scan.coverity.com/projects/libreoffice?tab=overview
