sc/source/ui/navipi/content.cxx | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
New commits: commit 19baf3a25f2cf3c5fe31be0e3946f078adbe032f Author: Caolán McNamara <[email protected]> AuthorDate: Fri Oct 31 20:44:43 2025 +0000 Commit: Caolán McNamara <[email protected]> CommitDate: Fri Oct 31 23:10:26 2025 +0100 cid#1668262 Unchecked return value and cid#1668261 Unchecked return value Change-Id: I10c8f8c6b60e33627ec1b15bc7ce99e220fe7317 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193284 Reviewed-by: Caolán McNamara <[email protected]> Tested-by: Jenkins diff --git a/sc/source/ui/navipi/content.cxx b/sc/source/ui/navipi/content.cxx index e47b60a64d37..520fd947a661 100644 --- a/sc/source/ui/navipi/content.cxx +++ b/sc/source/ui/navipi/content.cxx @@ -1545,27 +1545,26 @@ void ScContentTree::BringCommentToAttention(sal_uInt16 nCommentId) m_xTreeView->set_cursor(*xIter); m_xTreeView->select(*xIter); m_xTreeView->expand_row(*xIter); - sal_uInt32 nCount = m_xTreeView->iter_n_children(*xIter); - m_xTreeView->iter_children(*xIter); std::vector<sc::NoteEntry> aEntries; - ScDocument* pDoc= GetSourceDocument(); + ScDocument* pDoc = GetSourceDocument(); pDoc->GetAllNoteEntries(aEntries); - if (aEntries.size() != nCount) { + if (aEntries.size() != static_cast<size_t>(m_xTreeView->iter_n_children(*xIter))) { SAL_WARN("sc", "number of comments and children count does not match."); return; } - for (sal_uInt32 i = 0; i < nCount; ++i) + size_t i = 0; + for (bool bChild = m_xTreeView->iter_children(*xIter); bChild; + bChild = m_xTreeView->iter_next_sibling(*xIter)) { - const ScPostIt* pPostIt = aEntries[i].mpNote; + const ScPostIt* pPostIt = aEntries[i++].mpNote; if (pPostIt && pPostIt->GetId() == nCommentId) { m_xTreeView->select(*xIter); break; } - m_xTreeView->iter_next(*xIter); } break; }
