sc/source/ui/dbgui/tpsort.cxx | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
New commits: commit de01d6f6e5637726e99273f257df348118643cb3 Author: Regina Henschel <[email protected]> AuthorDate: Fri Nov 7 11:34:15 2025 +0100 Commit: Regina Henschel <[email protected]> CommitDate: Sat Nov 8 14:33:46 2025 +0100 tdf#168905 If sort by row, include affects columns If the direction is by row, that is top-down, then the options 'Include boundary Foo containing only comments/images' affect boundary columns. 'Foo' was incorrectly 'row'. This has led to confusion, which is evident in the comments in the bug report. Change-Id: I3aec22f1a12b1c581e7f0d9e64ad8d7aeff8d428 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193576 Reviewed-by: Regina Henschel <[email protected]> Tested-by: Jenkins diff --git a/sc/source/ui/dbgui/tpsort.cxx b/sc/source/ui/dbgui/tpsort.cxx index be0cfdc00732..caafc07b800f 100644 --- a/sc/source/ui/dbgui/tpsort.cxx +++ b/sc/source/ui/dbgui/tpsort.cxx @@ -720,15 +720,16 @@ void ScTabPageSortOptions::ActivatePage( const SfxItemSet& rSet ) if (!pDlg) return; + //tdf#168905 If sort by row, then include affects boundary columns. if (aSortData.bByRow) { - m_xBtnIncComments->set_label(aStrCommentsRowLabel); - m_xBtnIncImages->set_label(aStrImgRowLabel); + m_xBtnIncComments->set_label(aStrCommentsColLabel); + m_xBtnIncImages->set_label(aStrImgColLabel); } else { - m_xBtnIncComments->set_label(aStrCommentsColLabel); - m_xBtnIncImages->set_label(aStrImgColLabel); + m_xBtnIncComments->set_label(aStrCommentsRowLabel); + m_xBtnIncImages->set_label(aStrImgRowLabel); } }
