On 04/15/2013 03:19 PM, Janit Anjaria wrote:
I am hereby attaching my patch for fdo #62096 :

https://bugs.freedesktop.org/show_bug.cgi?id=62096

Any suggestions would be great to be implemented.

First, note that

  s.compareTo(t) != 0

is /not/ the same as

  s == t

Second, did you build and test your change? It looks like sal/qa/rtl/process/child_process.cxx is one of those rotting tests that is not built nor executed, not even with a top-level "make check".

Also, please take care not to mess up the indentation of lines, making the "if" indented only three instead of four spaces.

Stephan
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to